linux-kernel - Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130612050829.GB4107@intel.com>
Date:	Wed, 12 Jun 2013 10:38:29 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.jf.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	spear-devel <spear-devel@...t.st.com>, viresh.kumar@...aro.org,
	Arnd Bergmann <arnd@...db.de>, Felipe Balbi <balbi@...com>
Subject: Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote:
> The dw_dmac driver is going to be split into multiple files. To make this more
> convenient move it to an own directory.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> ---
> +config DW_DMAC
> +	tristate "Synopsys DesignWare AHB DMA support"
> +	depends on GENERIC_HARDIRQS
> +	select DMA_ENGINE
> +	default y if CPU_AT32AP7000
> +	help
> +	  Support the Synopsys DesignWare AHB DMA controller. This
> +	  can be integrated in chips such as the Atmel AT32ap7000.
> +
> +config DW_DMAC_BIG_ENDIAN_IO
> +	bool "Use big endian I/O register access"
> +	default y if AVR32
> +	depends on DW_DMAC
> +	help
> +	  Say yes here to use big endian I/O access when reading and writing
> +	  to the DMA controller registers. This is needed on some platforms,
> +	  like the Atmel AVR32 architecture.
I know this is derived but should it be selected if AVR32 is defined, this stuff
should be user configurable..

> +
> +	  If unsure, use the default setting.
> diff --git a/drivers/dma/dw/Makefile b/drivers/dma/dw/Makefile
> new file mode 100644
> index 0000000..dd8d993
> --- /dev/null
> +++ b/drivers/dma/dw/Makefile
> @@ -0,0 +1 @@
> +obj-$(CONFIG_DW_DMAC) += dw_dmac.o
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw/dw_dmac.c
> similarity index 99%
> rename from drivers/dma/dw_dmac.c
> rename to drivers/dma/dw/dw_dmac.c
> index 2b65ba6..15f3f4f 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw/dw_dmac.c
> @@ -28,8 +28,8 @@
>  #include <linux/acpi.h>
>  #include <linux/acpi_dma.h>
>  
> +#include "../dmaengine.h"
>  #include "dw_dmac_regs.h"
> -#include "dmaengine.h"
>  
>  /*
>   * This supports the Synopsys "DesignWare AHB Central DMA Controller",
> diff --git a/drivers/dma/dw_dmac_regs.h b/drivers/dma/dw/dw_dmac_regs.h
> similarity index 100%
> rename from drivers/dma/dw_dmac_regs.h
> rename to drivers/dma/dw/dw_dmac_regs.h
> -- 
> 1.8.2.rc0.22.gb3600c3
> 
--
~Vinod
-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/