linux-kernel - Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51B91E32.2040502@asianux.com>
Date:	Thu, 13 Jun 2013 09:19:46 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
CC:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Mike Frysinger <vapier@...too.org>, takata@...ux-m32r.org,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Arnd Bergmann <arnd@...db.de>,
	realmz paranoid <realmz6@...il.com>, linux390@...ibm.com,
	"uclinux-dist-devel@...ckfin.uclinux.org" 
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-m32r@...linux-m32r.org, linux-m32r-ja@...linux-m32r.org,
	linux-s390@...r.kernel.org,
	Linux-Arch <linux-arch@...r.kernel.org>,
	Marc Gauthier <Marc.Gauthier@...silica.com>
Subject: Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param,
 use 'unsigned int' instead of 'unsigned long'

On 06/10/2013 05:21 PM, Heiko Carstens wrote:
> On Sun, Jun 09, 2013 at 02:31:42PM +0800, Chen Gang wrote:
>> > 
>> > atomic_set_mask() and atomic_clear_mask() are the pairs, so the related
>> > parameters' type need match with each other.
>> > 
>> > The type of 'addr->counter' is 'int', so use 'unsigned int' instead
>> > of 'unsigned long', and let atomic_set_mask() match atomic_clear_mask().
>> > 
>> > 
>> > For arch sub-system, currently, have 3 types of definition for them:
>> > 1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'.
>> > 
>> > At least, better to fix 3rd (conflict using 'int' and 'long').
>> > 
>> > Signed-off-by: Chen Gang <gang.chen@...anux.com>
>> > ---
>> >  arch/blackfin/include/asm/atomic.h |    4 ++--
>> >  arch/m32r/include/asm/atomic.h     |    8 ++++----
>> >  arch/s390/include/asm/atomic.h     |    4 ++--
>> >  include/asm-generic/atomic.h       |    2 +-
>> >  4 files changed, 9 insertions(+), 9 deletions(-)
> For the s390 part:
> 
> Acked-by: Heiko Carstens <heiko.carstens@...ibm.com>
> 

Thank you very much !!


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/