linux-kernel - RE: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <150901ce682e$1c3fca50$54bf5ef0$%kim@samsung.com>
Date:	Thu, 13 Jun 2013 21:04:09 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Doug Anderson' <dianders@...omium.org>,
	'Linus Walleij' <linus.walleij@...aro.org>
Cc:	'Tomasz Figa' <tomasz.figa@...il.com>,
	'Olof Johansson' <olof@...om.net>,
	'Simon Glass' <sjg@...omium.org>,
	'Luigi Semenzato' <semenzato@...omium.org>,
	ilho215.lee@...sung.com, eunki_kim@...sung.com,
	linux-kernel@...r.kernel.org
Subject: RE: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before
 unmasking

Doug Anderson wrote:
> 
> A level-triggered interrupt should be acked after the interrupt line
> becomes inactive and before it is unmasked, or else another interrupt
> will be immediately triggered.  Acking before or after calling the
> handler is not enough.
> 
> Signed-off-by: Luigi Semenzato <semenzato@...omium.org>
> Signed-off-by: Doug Anderson <dianders@...omium.org>

BTW, probably we need a similar fixing in the mach-exynos/common.c file
before pinctąâ for distro...

Anyway,
Acked-by: Kukjin Kim <kgene.kim@...sung.com>

Thanks,
- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/