linux-kernel - Re: [PATCH v3 net-next 3/4] net: change sysctl_net_ll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371137471.3252.110.camel@edumazet-glaptop>
Date:	Thu, 13 Jun 2013 08:31:11 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Eliezer Tamir <eliezer.tamir@...ux.intel.com>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	e1000-devel@...ts.sourceforge.net,
	Willem de Bruijn <willemb@...gle.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	Andi Kleen <andi@...stfloor.org>, HPA <hpa@...or.com>,
	Eilon Greenstien <eilong@...adcom.com>,
	Or Gerlitz <or.gerlitz@...il.com>,
	Amir Vadai <amirv@...lanox.com>,
	Alex Rosenbaum <alexr@...lanox.com>,
	Avner Ben Hanoch <avnerb@...lanox.com>,
	Or Kehati <ork@...lanox.com>, sockperf-dev@...glegroups.com,
	Eliezer Tamir <eliezer@...ir.org.il>
Subject: Re: [PATCH v3 net-next 3/4] net: change sysctl_net_ll_poll into an
 unsigned int

On Thu, 2013-06-13 at 17:46 +0300, Eliezer Tamir wrote:
> There is no reason for sysctl_net_ll_poll to be an unsigned long.
> Change it into an unsigned int.
> Fix the proc handler.
> 
> Signed-off-by: Eliezer Tamir <eliezer.tamir@...ux.intel.com>
> ---
> 
>  include/net/ll_poll.h      |    2 +-
>  net/core/sysctl_net_core.c |    4 ++--
>  net/socket.c               |    2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/net/ll_poll.h b/include/net/ll_poll.h
> index c75a611..9f7007f 100644
> --- a/include/net/ll_poll.h
> +++ b/include/net/ll_poll.h
> @@ -30,7 +30,7 @@
>  #ifdef CONFIG_NET_LL_RX_POLL
>  
>  struct napi_struct;
> -extern unsigned long sysctl_net_ll_poll __read_mostly;
> +extern unsigned int sysctl_net_ll_poll __read_mostly;
>  

Oh well, you re-introduce the overflow

hint : you defined 

#define USECS_TO_NS(us) (us << 10)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/