linux-kernel - Re: [PATCH v2 3/4] gpu: host1x: add runtime pm support for dc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130613184938.GE32574@mithrandir>
Date:	Thu, 13 Jun 2013 20:49:39 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Mayuresh Kulkarni <mkulkarni@...dia.com>
Cc:	tbergstrom@...dia.com, amerilainen@...dia.com,
	thierry.reding@...onic-design.de, airlied@...hat.com,
	dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] gpu: host1x: add runtime pm support for dc

On Thu, Jun 13, 2013 at 03:23:37PM +0530, Mayuresh Kulkarni wrote:
[...]
> diff --git a/drivers/gpu/host1x/drm/dc.c b/drivers/gpu/host1x/drm/dc.c
[...]
> @@ -1128,9 +1129,7 @@ static int tegra_dc_probe(struct platform_device *pdev)
>  		return PTR_ERR(dc->clk);
>  	}
>  
> -	err = clk_prepare_enable(dc->clk);
> -	if (err < 0)
> -		return err;
> +	platform_set_drvdata(pdev, dc);

Why do you move the call to platform_set_drvdata() up here?

Thierry

Content of type "application/pgp-signature" skipped