linux-kernel - Re: [RFC: PATCH] err.h: silence warning when using IS_ERR on void _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Jun 2013 21:19:30 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Thierry Reding <thierry.reding@...il.com>
CC:	Sachin Kamat <sachin.kamat@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [RFC: PATCH] err.h: silence warning when using IS_ERR on void
 __iomem *

On 06/13/2013 08:24 PM, Thierry Reding wrote:
> On Thu, Jun 13, 2013 at 10:55:17AM +0530, Sachin Kamat wrote:
>> On 13 June 2013 03:01, Marc Kleine-Budde <mkl@...gutronix.de> wrote:
>>> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
>>> introduced devm_ioremap_resource() and encourage to check its return value with
>>> IS_ERR(). This however leads to the following sparse warnings, as
>>> devm_ioremap_resource() returns a void __iomem pointer:
>>>
>>> drivers/net/can/c_can/c_can_platform.c:205:32: warning: incorrect type in argument 1 (different address spaces)
>>> drivers/net/can/c_can/c_can_platform.c:205:32:    expected void const *ptr
>>> drivers/net/can/c_can/c_can_platform.c:205:32:    got unsigned int [noderef] [usertype] <asn:2>*raminit_ctrlreg
>>
>> CC ing Thierry who has solved this issue some time back.
> 
> I had sent two patches, one against sparse, the other against the
> kernel, but none were picked up yet.

Can you repost them? Hope someone will pick them up.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)