linux-kernel - Re: [PATCH v3] ethernet/arc/arc_emac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130613.125421.1518137499194108848.davem@davemloft.net>
Date:	Thu, 13 Jun 2013 12:54:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	andy.shevchenko@...il.com, Alexey.Brodkin@...opsys.com,
	netdev@...r.kernel.org, romieu@...zoreil.com,
	Vineet.Gupta1@...opsys.com, Mischa.Jonker@...opsys.com,
	arnd@...db.de, grant.likely@...aro.org, rob.herring@...xeda.com,
	paul.gortmaker@...driver.com, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH v3] ethernet/arc/arc_emac - Add new driver

From: Joe Perches <joe@...ches.com>
Date: Thu, 13 Jun 2013 11:33:21 -0700

> On Thu, 2013-06-13 at 21:25 +0300, Andy Shevchenko wrote:
>> On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin
>> > +               if (unlikely((info & OWN_MASK) == FOR_EMAC)) {
>> > +                       /* BD is still owned by EMAC */
>> > +                       continue;
>> > +               }
>> 
>> Redundant braces.
> 
> Maybe not.  Braces can be a visual aid when there is
> a comment in the test.

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/