linux-kernel - Re: [PATCH] netiucv: Hold rtnl between name allocation and device registration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130613.174154.4560842535243312.davem@davemloft.net>
Date:	Thu, 13 Jun 2013 17:41:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bpoirier@...e.de
Cc:	linux-s390@...r.kernel.org, netdev@...r.kernel.org,
	ursula.braun@...ibm.com, linux390@...ibm.com,
	blaschka@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, cornelia.huck@...ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netiucv: Hold rtnl between name allocation and device
 registration.

From: Benjamin Poirier <bpoirier@...e.de>
Date: Thu, 13 Jun 2013 09:09:47 -0400

> fixes a race condition between concurrent initializations of netiucv devices
> that try to use the same name.
> 
> sysfs: cannot create duplicate filename '/devices/iucv/netiucv2'
> [...]
> Call Trace:
> ([<00000000002edea4>] sysfs_add_one+0xb0/0xdc)
>  [<00000000002eecd4>] create_dir+0x80/0xfc
>  [<00000000002eee38>] sysfs_create_dir+0xe8/0x118
>  [<00000000003835a8>] kobject_add_internal+0x120/0x2d0
>  [<00000000003839d6>] kobject_add+0x62/0x9c
>  [<00000000003d9564>] device_add+0xcc/0x510
>  [<000003e00212c7b4>] netiucv_register_device+0xc0/0x1ec [netiucv]
> 
> Signed-off-by: Benjamin Poirier <bpoirier@...e.de>
> Tested-by: Ursula Braun <braunu@...ibm.com>

Yes as dev_alloc_name() must be invoked under RTNL or dev_base_lock, this
fix is correct.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/