linux-kernel - Re: [PATCH] tracing/kprobes: remove unnecessary checking of, trace_probe_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51BA87DB.1020403@hitachi.com>
Date:	Fri, 14 Jun 2013 12:02:51 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Oleg Nesterov <oleg@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"yrl.pp-manager.tt@...achi.com" <yrl.pp-manager.tt@...achi.com>
Subject: Re: [PATCH] tracing/kprobes: remove unnecessary checking of, trace_probe_is_enabled

(2013/06/14 11:10), zhangwei(Jovi) wrote:
> Since tp->flags assignment was moved into function enable_trace_probe,
> so there have no need to use trace_probe_is_enabled to check flags
> in same function.

Indeed :)

> 
> Remove the unnecessary checking.


Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>

> 
> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@...wei.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
> ---
>  kernel/trace/trace_kprobe.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index 9f46e98..f237417 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -240,8 +240,7 @@ enable_trace_probe(struct trace_probe *tp, struct ftrace_event_file *file)
>  	} else
>  		tp->flags |= TP_FLAG_PROFILE;
> 
> -	if (trace_probe_is_enabled(tp) && trace_probe_is_registered(tp) &&
> -	    !trace_probe_has_gone(tp)) {
> +	if (trace_probe_is_registered(tp) && !trace_probe_has_gone(tp)) {
>  		if (trace_probe_is_return(tp))
>  			ret = enable_kretprobe(&tp->rp);
>  		else
> 


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/