lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87ehc2rczo.fsf@rustcorp.com.au>
Date:	Sun, 16 Jun 2013 12:14:11 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Julia Lawall <julia.lawall@...6.fr>,
	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Julia Lawall <julia.lawall@...6.fr>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, Thomas Meyer <thomas@...3r.de>,
	grant.likely@...aro.org, rob.herring@...xeda.com,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC] PTR_ERR: return 0 if ptr isn't an error value.

Julia Lawall <julia.lawall@...6.fr> writes:
> On Thu, 13 Jun 2013, Michael S. Tsirkin wrote:
>
>> On Thu, Jun 13, 2013 at 02:07:40PM +0930, Rusty Russell wrote:
>> > I think using PTR_ERR() is a less bad solution than promoting PTR_RET,
>> > which has a non-obvious name.
>>
>> Will a longer name make the function more obvious?
>> 	PTR_ERR_OR_ZERO() ?
>> 	PTR_ERR0() ?
>> PTR_ERR() can then stay simple for cases where we know we
>> are on the error path.
>
> I was thinking of something along those lines.  And in that case, PTR_ERR
> could stay without the additional test.
> julia

OK, sold :)

Will send out a series now with PTR_ERR_OR_ZERO.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ