linux-kernel - Re: mod filenames != modnames? (inconsistent name changing)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 16 Jun 2013 15:05:29 +0930
From:	Rusty Russell <rusty@...abs.org>
To:	Linda Walsh <lkml@...nx.org>,
	Linux-Kernel <linux-kernel@...r.kernel.org>
Cc:	"ACPI Devel Maling List" <linux-acpi@...r.kernel.org>,
	<kvm@...r.kernel.org>
Subject: Re: mod filenames != modnames? (inconsistent name changing)

Linda Walsh <lkml@...nx.org> writes:
> Should we have any expectation that a module name and it's filename
> should be equivalent?
>
> I was writing an auto-complete script for modprobe so it wouldn't give
> me the option to double load a module (I'd have to manually type it in if
> I really wanted it).
>
> Trouble is some modules with names w/underscores ('_') change
> register their names with a 'dash'.

But modprobe kvm_intel already works.  Just convert any - to _?

> Would it be too much trouble to ask that the same names be used in
> both places?

Well, you could get kernel developers to rename their files with
underscores.  I've CC'd them.

We use _ because we turn the module names into identifiers; it's also
the most common choice, and having both is just confusing.

> I have about 30 modules loaded now and out of that list,
> 2 are name changes:
>
> acpi_cpufreq  (filename acip-cpufreq.ko)
> kvm_intel     (filename kvm-intel.ko)
>
> If I load a bunch more... I find more that change names.
>
> Could the naming in the modules that do this be made consistent?
>
> Not doing so makes automatically tying a mod-name to it's file
> tend toward being non-deterministic.
>
> Many modules use '-' or '_' without being confused.
> It would be helpful if the few confused modules could
> get their identity straight.  Is there a problem with
> making these names consistent?

It shouldn't break anything to rename them, if there's consensus I'm
happy to create a patch.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/