linux-kernel - Re: sound/oss/ad1848.c:2867:32: warning: ‘id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hli69npal.wl%tiwai@suse.de>
Date:	Mon, 17 Jun 2013 09:56:34 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Tommi Rantala <tt.rantala@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: sound/oss/ad1848.c:2867:32: warning: ‘id_table’ defined but not used

At Thu, 13 Jun 2013 18:23:02 +0300,
Tommi Rantala wrote:
> 
> Hello, I'm seeing the following compiler warning, does it look useful?
> I'm doing a v3.10-rc5 x86-64 build.
> 
> /build/linux/sound/oss/ad1848.c:2867:32: warning: ‘id_table’ defined
> but not used [-Wunused-variable]
> 
> $ gcc --version
> gcc (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
> Copyright (C) 2012 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> 
> config:
> http://fpaste.org/18443/13711363/

It's because CONFIG_ISAPNP isn't set (it's optional).  You can add
ifdef to hide the warning, but it makes the code uglier, OTOH.

Since this driver is a legacy one and almost no one uses it, better to
save your time for more useful things, I'd say :)


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/