linux-kernel - Re: [PATCH v2 4/7] mm/page_alloc: fix blank in show_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130617081012.GA19194@dhcp22.suse.cz>
Date:	Mon, 17 Jun 2013 10:10:12 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	David Rientjes <rientjes@...gle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Rik van Riel <riel@...hat.com>,
	Andrew Shewmaker <agshew@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Namjae Jeon <linkinjeon@...il.com>, Jan Kara <jack@...e.cz>,
	Tejun Heo <tj@...nel.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/7] mm/page_alloc: fix blank in show_free_areas

On Sun 16-06-13 09:14:47, Wanpeng Li wrote:
> There is a blank in show_free_areas which lead to dump messages aren't
> aligned. This patch remove blank.
> 
> Before patch:
> 
> [155219.720141] active_anon:50675 inactive_anon:35273 isolated_anon:0
> [155219.720141]  active_file:215421 inactive_file:344268 isolated_file:0
> [155219.720141]  unevictable:0 dirty:35 writeback:0 unstable:0
> [155219.720141]  free:1334870 slab_reclaimable:28833 slab_unreclaimable:5115
> [155219.720141]  mapped:25233 shmem:35511 pagetables:1705 bounce:0
> [155219.720141]  free_cma:0
> 
> After patch:
> 
> [   73.913889] active_anon:39578 inactive_anon:32082 isolated_anon:0
> [   73.913889] active_file:14621 inactive_file:57993 isolated_file:0
> [   73.913889] unevictable:0dirty:263 writeback:0 unstable:0
> [   73.913889] free:1865614 slab_reclaimable:3264 slab_unreclaimable:4566
> [   73.913889] mapped:21192 shmem:32327 pagetables:1572 bounce:0
> [   73.913889] free_cma:0

Not that I would care much but this format is here for ages. An
additional space was kind of nice to visually separate this part from
the per-zone data.

Is there any special reason for this change?

> Signed-off-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
> ---
>  mm/page_alloc.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 18102e1..e6e881a 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3004,12 +3004,12 @@ void show_free_areas(unsigned int filter)
>  	}
>  
>  	printk("active_anon:%lu inactive_anon:%lu isolated_anon:%lu\n"
> -		" active_file:%lu inactive_file:%lu isolated_file:%lu\n"
> -		" unevictable:%lu"
> -		" dirty:%lu writeback:%lu unstable:%lu\n"
> -		" free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n"
> -		" mapped:%lu shmem:%lu pagetables:%lu bounce:%lu\n"
> -		" free_cma:%lu\n",
> +		"active_file:%lu inactive_file:%lu isolated_file:%lu\n"
> +		"unevictable:%lu"
> +		"dirty:%lu writeback:%lu unstable:%lu\n"

There is a space missing between unevictable and dirty.

> +		"free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n"
> +		"mapped:%lu shmem:%lu pagetables:%lu bounce:%lu\n"
> +		"free_cma:%lu\n",
>  		global_page_state(NR_ACTIVE_ANON),
>  		global_page_state(NR_INACTIVE_ANON),
>  		global_page_state(NR_ISOLATED_ANON),

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/