linux-kernel - Re: [PATCH v2 3/7] mm/writeback: commit reason of WB_REASON_FORKER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130617083030.GE19194@dhcp22.suse.cz>
Date:	Mon, 17 Jun 2013 10:30:30 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	David Rientjes <rientjes@...gle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Rik van Riel <riel@...hat.com>,
	Andrew Shewmaker <agshew@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Namjae Jeon <linkinjeon@...il.com>, Jan Kara <jack@...e.cz>,
	Tejun Heo <tj@...nel.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] mm/writeback: commit reason of
 WB_REASON_FORKER_THREAD mismatch name

On Sun 16-06-13 09:14:46, Wanpeng Li wrote:
> After commit 839a8e86("writeback: replace custom worker pool implementation
> with unbound workqueue"), there is no bdi forker thread any more. However,
> WB_REASON_FORKER_THREAD is still used due to it is somewhat userland visible 

What exactly "somewhat userland visible" means?
Is this about trace events?

> and we won't be exposing exactly the same information with just a different 
> name. 
> 
> Signed-off-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
> ---
>  include/linux/writeback.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
> index 8b5cec4..cf077a7 100644
> --- a/include/linux/writeback.h
> +++ b/include/linux/writeback.h
> @@ -47,6 +47,11 @@ enum wb_reason {
>  	WB_REASON_LAPTOP_TIMER,
>  	WB_REASON_FREE_MORE_MEM,
>  	WB_REASON_FS_FREE_SPACE,
> +/*
> + * There is no bdi forker thread any more and works are done by emergency
> + * worker, however, this is somewhat userland visible and we'll be exposing
> + * exactly the same information, so it has a mismatch name.
> + */
>  	WB_REASON_FORKER_THREAD,
>  
>  	WB_REASON_MAX,
> -- 
> 1.8.1.2
> 

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/