lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Jun 2013 10:55:22 +0100 From: Luis Henriques <luis.henriques@...onical.com> To: Ben Hutchings <ben@...adent.org.uk> Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org, akpm@...ux-foundation.org, "Sujith Manoharan" <c_manoha@....qualcomm.com>, "John W. Linville" <linville@...driver.com> Subject: Re: [68/83] ath9k: Disable PowerSave by default Ben Hutchings <ben@...adent.org.uk> writes: > 3.2.47-rc1 review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Sujith Manoharan <c_manoha@....qualcomm.com> > > commit 73c79617596b89a3693ff0d89d42bcd5ddedcf15 upstream. This SHA1 seems to be wrong, you probably meant 531671cb17af07281e6f28c1425f754346e65c41. Cheers, -- Luis > > Almost all the DMA issues which have plagued ath9k (in station mode) > for years are related to PS. Disabling PS usually "fixes" the user's > connection stablility. Reports of DMA problems are still trickling in > and are sitting in the kernel bugzilla. Until the PS code in ath9k is > given a thorough review, disbale it by default. The slight increase > in chip power consumption is a small price to pay for improved link > stability. > > Signed-off-by: Sujith Manoharan <c_manoha@....qualcomm.com> > Signed-off-by: John W. Linville <linville@...driver.com> > --- > drivers/net/wireless/ath/ath9k/init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/drivers/net/wireless/ath/ath9k/init.c > +++ b/drivers/net/wireless/ath/ath9k/init.c > @@ -691,8 +691,7 @@ void ath9k_set_hw_capab(struct ath_softc > BIT(NL80211_IFTYPE_ADHOC) | > BIT(NL80211_IFTYPE_MESH_POINT); > > - if (AR_SREV_5416(sc->sc_ah)) > - hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT; > + hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT; > > hw->wiphy->flags |= WIPHY_FLAG_IBSS_RSN; > > > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists