| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Jun 2013 15:47:36 +0200 From: Oliver Schinagl <oliver+list@...inagl.nl> To: Tomasz Figa <t.figa@...sung.com> CC: linux-arm-kernel@...ts.infradead.org, Tomasz Figa <tomasz.figa@...il.com>, linux@....linux.org.uk, arnd@...db.de, Oliver Schinagl <oliver@...inagl.nl>, gregkh@...uxfoundation.org, linus.walleij@...aro.org, linux-kernel@...r.kernel.org, andy.shevchenko@...il.com, maxime.ripard@...e-electrons.com, linux-sunxi@...glegroups.com Subject: Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses On 17-06-13 15:23, Tomasz Figa wrote: > On Monday 17 of June 2013 15:10:47 Oliver Schinagl wrote: >> On 17-06-13 14:51, Tomasz Figa wrote: >>> On Monday 17 of June 2013 12:36:47 Oliver Schinagl wrote: >>>> On 15-06-13 12:28, Tomasz Figa wrote: <snip> >> Now we pass this array to add_randomness(array, 16). So add_randomness >> sees 16 ints in an array. So while there will be a lot of extra zero's, >> there still be 16 elements copied/processed, no? > > The second argument of add_randomness is number of bytes, not number of > elements in array, as far as I can tell. Oh wow, very good catch. I had to dig a little into the source where it said 'nbytes'. I guess the function prototype would have been nicer if it said nbytes instead of size. Anyway, with using an array of u8 this is nicely handled. > Best regards, > Tomasz > oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists