linux-kernel - Re: [PATCH] dmatest: masking tests for channel capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51BF3170.6090802@intel.com>
Date:	Mon, 17 Jun 2013 08:55:28 -0700
From:	Dave Jiang <dave.jiang@...el.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
CC:	Jubin Mehta <jubin.mehta@...el.com>,
	Vinod Koul <vinod.koul@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dan Williams <djbw@...com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Jon Mason <jon.mason@...el.com>
Subject: Re: [PATCH] dmatest: masking tests for channel capabilities

On 06/17/2013 01:59 AM, Andy Shevchenko wrote:
> On Thu, Jun 13, 2013 at 8:24 PM, Jubin Mehta <jubin.mehta@...el.com> wrote:
>> +++ b/drivers/dma/dmatest.c
>> +/*
>> + * Capability Mask Bits.The bits in the cap_mask denote the masking of
>> + * the hardware capabilities of the dma channel.
>> + *
>> + * DMA_CAP_MEMCPY:  Bit 0 for enabling DMA_MEMCPY capability
>> + * DMA_CAP_XOR:     Bit 1 for enabling DMA_XOR capabilit
>> + * DMA_CAP_PQ:      Bit 2 for enabling DMA_PQ capability
>> + * DMA_CAP_ALL:     Enable all the capabilities of the channel
>> + */
>> +#define DMA_CAP_MEMCPY         (1 << 0)
>> +#define DMA_CAP_XOR            (1 << 1)
>> +#define DMA_CAP_PQ             (1 << 2)
> Can we reuse DMA_MEMCPY and so on from enum dma_transaction_type?

The issue is that the originals are enum types. We can't pass bitmap 
type (dma_cap_mask_t) through sysfs. So to use those enums for what we 
want to do it would have to be someting like:
(1 << DMA_MEMCPY)

And also in that case for user scripts you have bits that are here and 
there for the bitmask instead of something simple and sequential.

-- 

Dave Jiang
Application Engineer, Storage Divsion
Intel Corp.
dave.jiang@...el.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/