linux-kernel - Re: [PATCH 11/15] regulator: ti-abb: Convert to use devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130617160853.GG1403@sirena.org.uk>
Date:	Mon, 17 Jun 2013 17:08:53 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	linux-kernel@...r.kernel.org, thierry.reding@...il.com,
	patches@...aro.org, Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH 11/15] regulator: ti-abb: Convert to use
 devm_ioremap_resource

On Mon, Jun 17, 2013 at 04:04:52PM +0530, Tushar Behera wrote:
> On 06/17/2013 03:35 PM, Mark Brown wrote:
> > On Mon, Jun 17, 2013 at 02:42:25PM +0530, Tushar Behera wrote:

> >> Ping.
i
> > Don't send contentless pings.  I seem to recall you already got some
> > review on this.

> 
> The comment was on removal of the error message during
> devm_ioremap_resource() error check . Since there are a few other error
> messages in the driver (related to devm_ioremap_nocache) in the same
> format, I prefer to leave this error message right now.

So we should say the same thing repeatedly?  That seems silly.  That
seems silly.   It's like the contentless pings issue...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)