linux-kernel - Re: [PATCH Resend] pinctrl: exynos: Fix build breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZe7U7G4dKZO+PyKxM6EO9xQSwxPGXwTZerj45t86+GPA@mail.gmail.com>
Date:	Mon, 17 Jun 2013 18:18:39 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Tomasz Figa <t.figa@...sung.com>
Cc:	Sachin Kamat <sachin.kamat@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	Patch Tracking <patches@...aro.org>,
	Doug Anderson <dianders@...omium.org>
Subject: Re: [PATCH Resend] pinctrl: exynos: Fix build breakage

On Mon, Jun 17, 2013 at 1:57 PM, Tomasz Figa <t.figa@...sung.com> wrote:
> On Monday 17 of June 2013 15:08:12 Sachin Kamat wrote:
>> 'exynos_wkup_irq_ack' should be defined ahead of its call.
>>
>> Fixes the following error:
>> drivers/pinctrl/pinctrl-exynos.c: In function ‘exynos_wkup_irq_mask’:
>> drivers/pinctrl/pinctrl-exynos.c:299:3: error: implicit declaration of
>> function ‘exynos_wkup_irq_ack’ [-Werror=implicit-function-declaration]
>>    exynos_wkup_irq_ack(irqd);
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
>> Cc: Doug Anderson <dianders@...omium.org>
>> ---
>> Fixed the commit message.
>> ---
>
> This patch is incorrect.
>
> Compilation error is caused by merge error of Doug's patch:
>
> pinctrl: exynos: ack level-triggered interrupts before unmasking
>
> hunk of which went to wrong function - mask instead of unmask.

OK probably I just had git am fail on me and used
patch -p1 < ...

> Linus, could you fix it?

No I'm afraid I will cause more trouble.

I took out Doug's commit and this fi from my tree.

Doug, can you respin the patch
"pinctrl: exynos: ack level-triggered interrupts before unmasking"

On top of my "devel" branch?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/