linux-kernel - Re: [PATCH v2 3/7] mm/writeback: commit reason of WB_REASON_FORKER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130617202706.GM32663@mtj.dyndns.org>
Date:	Mon, 17 Jun 2013 13:27:06 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Michal Hocko <mhocko@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Rientjes <rientjes@...gle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Rik van Riel <riel@...hat.com>,
	Andrew Shewmaker <agshew@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Namjae Jeon <linkinjeon@...il.com>, Jan Kara <jack@...e.cz>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] mm/writeback: commit reason of
 WB_REASON_FORKER_THREAD mismatch name

On Mon, Jun 17, 2013 at 05:41:44PM +0800, Wanpeng Li wrote:
> On Mon, Jun 17, 2013 at 10:30:30AM +0200, Michal Hocko wrote:
> >On Sun 16-06-13 09:14:46, Wanpeng Li wrote:
> >> After commit 839a8e86("writeback: replace custom worker pool implementation
> >> with unbound workqueue"), there is no bdi forker thread any more. However,
> >> WB_REASON_FORKER_THREAD is still used due to it is somewhat userland visible 
> >
> >What exactly "somewhat userland visible" means?
> >Is this about trace events?
> 
> Thanks for the question, Tejun, could you explain this for us? ;-)

Yeah, I was referring to the WB_REASON strings in
include/trace/events/writeback.h.  We can rename the internal constant
and leave the string alone too but I don't think it matters either
way.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/