linux-kernel - Re: [PATCH] usb: host: Faraday fotg210-hcd driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Jun 2013 13:39:48 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Yuan-Hsin Chen <yhchen@...aday-tech.com>
Cc:	stern@...land.harvard.edu, sarah.a.sharp@...ux.intel.com,
	balbi@...com, florian@...nwrt.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, yuanlmm@...il.com,
	ratbert.chuang@...il.com, john453@...aday-tech.com
Subject: Re: [PATCH] usb: host: Faraday fotg210-hcd driver

On Wed, Jun 05, 2013 at 05:15:43PM +0000, Yuan-Hsin Chen wrote:
> FOTG210 is an OTG controller which can be configured as an
> USB2.0 host. FOTG210 host is an ehci-like controller with
> some differences. First, register layout of FOTG210 is
> incompatible with EHCI. Furthermore, FOTG210 is lack of
> siTDs which means iTDs are used for both HS and FS ISO
> transfer.
> 
> Signed-off-by: Yuan-Hsin Chen <yhchen@...aday-tech.com>
> ---
>  drivers/usb/Makefile           |    1 +
>  drivers/usb/host/Kconfig       |   12 +
>  drivers/usb/host/Makefile      |    1 +
>  drivers/usb/host/fotg210-hcd.c | 5967 ++++++++++++++++++++++++++++++++++++++++
>  drivers/usb/host/fotg210.h     |  746 +++++
>  5 files changed, 6727 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/host/fotg210-hcd.c
>  create mode 100644 drivers/usb/host/fotg210.h

You obviously didn't even run this through checkpatch.pl, did you?

$ ./scripts/checkpatch.pl --terse ../usb.mbox | tail -n 1
total: 138 errors, 618 warnings, 6742 lines checked

Please fix all of these if you wish us to at least start reviewing the
patch.  Your internal Q/A should have caught this first, please be more
careful in the future.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/