linux-kernel - Re: [PATCH 3/8] FMC: add core bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130617231606.GB12984@kroah.com>
Date:	Mon, 17 Jun 2013 16:16:06 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Alessandro Rubini <rubini@...dd.com>
Cc:	linux-kernel@...r.kernel.org,
	Juan David Gonzalez Cobas <juan.david.gonzalez.cobas@...n.ch>,
	"Emilio G. Cota" <cota@...ap.org>,
	Samuel Iglesias Gonsalvez <siglesias@...lia.com>,
	Rob Landley <rob@...dley.net>, linux-doc@...r.kernel.org
Subject: Re: [PATCH 3/8] FMC: add core bus driver

On Wed, Jun 12, 2013 at 09:13:47AM +0200, Alessandro Rubini wrote:
> --- a/drivers/fmc/fmc-core.c
> +++ b/drivers/fmc/fmc-core.c
> @@ -1,13 +1,285 @@
> -/* Temporary placeholder so the empty code can build */
> +/*
> + * Copyright (C) 2012 CERN (www.cern.ch)
> + * Author: Alessandro Rubini <rubini@...dd.com>
> + *
> + * Released according to the GNU GPL, version 2 or any later version.

I have to ask, do you really mean "or any later version"?

> +int fmc_driver_register(struct fmc_driver *drv)
> +{
> +	if (fmc_check_version(drv->version, drv->driver.name))
> +		return -EINVAL;
> +	drv->driver.bus = &fmc_bus_type;
> +	return driver_register(&drv->driver);
> +}
> +EXPORT_SYMBOL(fmc_driver_register);
> +
> +void fmc_driver_unregister(struct fmc_driver *drv)
> +{
> +	driver_unregister(&drv->driver);
> +}
> +EXPORT_SYMBOL(fmc_driver_unregister);

Any specific reason these aren't EXPORT_SYMBOL_GPL()?

Again, just have to ask.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/