| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130617232739.GA4454@jack.whiskey> Date: Tue, 18 Jun 2013 01:27:39 +0200 From: Andi Shyti <andi.shyti@...il.com> To: Greg KH <gregkh@...uxfoundation.org> Cc: Andi Shyti <andi@...zian.org>, arnd@...db.de, linux-kernel@...r.kernel.org, pc@...f.org, oatilla@...il.com Subject: Re: [PATCH 01/19] bh1770glc: added input device interface Hi Greg, > > The driver generates an event in /dev/input/ under the name > > 'bh1770'. It's a switch event where is reported '0' or '1' > > whenever the sensor detects something crossing the threshold. > > > > Signed-off-by: Onur Atilla <oatilla@...il.com> > > Signed-off-by: Phil Carmody <pc@...f.org> > > Signed-off-by: Andi Shyti <andi@...zian.org> > > --- > > drivers/misc/bh1770glc.c | 58 +++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 57 insertions(+), 1 deletion(-) > > Doesn't this mean that this driver is now an "input" driver, so it > shouldn't be using the odd sysfs api, and should move to the > drivers/input/ directory tree? The driver has also lots of interfaces in sysfs that are used from userspace, like proximity value and ambient light value. What the input interface provides is just one of the features from the driver. Shall I move it anyway? Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists