linux-kernel - Re: [PATCH -next v3] thermal: fix x86_pkg_temp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371511724.22538.1.camel@rzhang1-mobl4>
Date:	Tue, 18 Jun 2013 07:28:44 +0800
From:	Zhang Rui <rui.zhang@...el.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Randy Dunlap <rdunlap@...radead.org>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Linux PM list <linux-pm@...r.kernel.org>
Subject: Re: [PATCH -next v3] thermal:  fix x86_pkg_temp_thermal.c build and
 Kconfig

On Mon, 2013-06-17 at 21:45 +0200, Borislav Petkov wrote:
> On Mon, Jun 17, 2013 at 12:27:17PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@...radead.org>
> > 
> > Fix build error in x86_pkg_temp_thermal.c.  It requires that
> > X86_MCE & X86_THERMAL_VECTOR be enabled, so depend on the latter symbol,
> > since it depends on X86_MCE (indirectly).
> > 
> > Also, X86_PKG_TEMP_THERMAL is already inside an "if THERMAL" block,
> > so remove that duplicated dependency.
> > 
> > ERROR: "platform_thermal_package_rate_control" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined!
> > ERROR: "platform_thermal_package_notify" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined!
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > ---
> >  drivers/thermal/Kconfig |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > --- linux-next-20130617.orig/drivers/thermal/Kconfig
> > +++ linux-next-20130617/drivers/thermal/Kconfig
> > @@ -171,8 +171,7 @@ config INTEL_POWERCLAMP
> >  
> >  config X86_PKG_TEMP_THERMAL
> >  	tristate "X86 package temperature thermal driver"
> > -	depends on THERMAL
> > -	depends on X86
> > +	depends on X86_THERMAL_VECTOR
> >  	select THERMAL_GOV_USER_SPACE
> >  	default m
> >  	help
> 
> Acked-by: Borislav Petkov <bp@...e.de>
> 
applied to thermal -next.

thanks,
rui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/