linux-kernel - Re: [PATCH 02/15] sudmac: Convert to use devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51BEA896.6050206@linaro.org>
Date:	Mon, 17 Jun 2013 11:41:34 +0530
From:	Tushar Behera <tushar.behera@...aro.org>
To:	linux-kernel@...r.kernel.org
CC:	thierry.reding@...il.com, patches@...aro.org,
	Vinod Koul <vinod.koul@...el.com>, Dan Williams <djbw@...com>
Subject: Re: [PATCH 02/15] sudmac: Convert to use devm_ioremap_resource

On 06/10/2013 05:05 PM, Tushar Behera wrote:
> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
> introduced devm_ioremap_resource() and deprecated the use of
> devm_request_and_ioremap().
> 
> Signed-off-by: Tushar Behera <tushar.behera@...aro.org>
> CC: Vinod Koul <vinod.koul@...el.com>
> CC: Dan Williams <djbw@...com>
> ---
>  drivers/dma/sh/sudmac.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c
> index e7c94bb..0a81e30 100644
> --- a/drivers/dma/sh/sudmac.c
> +++ b/drivers/dma/sh/sudmac.c
> @@ -360,9 +360,9 @@ static int sudmac_probe(struct platform_device *pdev)
>  
>  	dma_dev = &su_dev->shdma_dev.dma_dev;
>  
> -	su_dev->chan_reg = devm_request_and_ioremap(&pdev->dev, chan);
> -	if (!su_dev->chan_reg)
> -		return err;
> +	su_dev->chan_reg = devm_ioremap_resource(&pdev->dev, chan);
> +	if (IS_ERR(su_dev->chan_reg))
> +		return PTR_ERR(su_dev->chan_reg);
>  
>  	dma_cap_set(DMA_SLAVE, dma_dev->cap_mask);
>  
> 

Ping.

-- 
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/