linux-kernel - Re: [PATCH] net: fec: Fix build for MCF5272

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130618.001943.965348712833625569.davem@davemloft.net>
Date:	Tue, 18 Jun 2013 00:19:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	linux@...ck-us.net
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Frank.Li@...escale.com, jim_baxter@...tor.com
Subject: Re: [PATCH] net: fec: Fix build for MCF5272

From: Guenter Roeck <linux@...ck-us.net>
Date: Mon, 17 Jun 2013 21:03:12 -0700

> On Mon, Jun 17, 2013 at 04:11:51PM -0700, David Miller wrote:
>> From: Guenter Roeck <linux@...ck-us.net>
>> Date: Mon, 17 Jun 2013 13:16:19 -0700
>> 
>> > Commits 4c09eed9 (net: fec: Enable imx6 enet checksum acceleration) and
>> > baa70a5c (net: fec: enable pause frame to improve rx prefomance for 1G
>> > network) introduced functionality into the FEC driver which is not
>> > supported on MCF5272. As result, building images for MCF5272 fails,
>> > complaining about several undefined symbols.
>> > 
>> > Disabled the added functionality for MCF5272 builds.
>> > 
>> > Cc: Frank Li <Frank.Li@...escale.com>
>> > Cc: Jim Baxter <jim_baxter@...tor.com>
>> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> > ---
>> > Sorry for the added ifdefs. If anyone has a better idea on how to fix
>> > the problems, let me know.
>> > 
>> > This problem exists in 3.9 as well.
>> 
>> Does the M5272 not have these registers, or have you simply not added
>> defines for where there offsets are in that silicon instance?
>> 
>> I'd much rather you add the register offset defines than pepper the
>> entire driver with ifdefs.
>> 
> I agree, and that would have been my preferred solution as well.
> Unfortunately, according to the user manual (MCF5272 ColdFire
> Integrated Microprocessor User's Manual), the registers do not exist
> on this chip.

Please explain this in your commit message instead of leaving it as
a mystery for the next person who look at this change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/