linux-kernel - Re: [PATCH] input: cros_ec_keyb_clear_keyboard() depends on CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVL=9m6zB_Jc+hE=iZr7LBT+vb9ckc2c-yxPJOvM-wrPQ@mail.gmail.com>
Date:	Tue, 18 Jun 2013 10:39:10 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Simon Glass <sjg@...omium.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	lk <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] input: cros_ec_keyb_clear_keyboard() depends on CONFIG_PM_SLEEP

On Tue, Jun 18, 2013 at 1:16 AM, Samuel Ortiz <sameo@...ux.intel.com> wrote:
> On Tue, May 14, 2013 at 11:42:48PM -0700, Dmitry Torokhov wrote:
>> On Wed, May 08, 2013 at 09:25:56PM -0600, Simon Glass wrote:
>> > On Wed, May 8, 2013 at 3:45 PM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>> > > If CONFIG_PM_SLEEP is not set:
>> > >
>> > > drivers/input/keyboard/cros_ec_keyb.c:211: warning: ‘cros_ec_keyb_clear_keyboard’ defined but not used
>> > >
>> > > Move the definition of cros_ec_keyb_clear_keyboard() inside the section
>> > > protected by #ifdef CONFIG_PM_SLEEP to fix this.
>> > >
>> > > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>> >
>> > Acked-by: Simon Glass <sjg@...omium.org>
>>
>> Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>>
>> Could you please forward this to Linus as I do not have this driver in
>> my branch yet.
> I guess you took that one now ? Or are you expecting me to merge it ?

FWIW, I also have it in my exotic-arch-fixes branch, now destined for 3.11.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/