lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Jun 2013 10:40:17 +0200 From: Samuel Ortiz <sameo@...ux.intel.com> To: Sachin Kamat <sachin.kamat@...aro.org> Cc: linux-kernel@...r.kernel.org, lee.jones@...aro.org, Miguel Aguilar <miguel.aguilar@...gerun.com> Subject: Re: [PATCH Resend 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs Hi Sachin, On Wed, Jun 12, 2013 at 01:49:42PM +0530, Sachin Kamat wrote: > devm_* APIs are device managed and make code simpler. > > Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org> > Cc: Miguel Aguilar <miguel.aguilar@...gerun.com> > --- > CC'd Lee Jones > > Patch is based on mfd-next tree and compile tested. > This driver gives following compilation error (not introduced by this patch): > drivers/mfd/davinci_voicecodec.c:86:3: error: implicit declaration > of function ‘io_v2p’ [-Werror=implicit-function-declaration] > (dma_addr_t)(io_v2p(davinci_vc->base) + DAVINCI_VC_WFIFO); > > In order to test my changes I added the following to davinci_voicecodec.h file: > +#define IO_OFFSET 0xfd000000 /* Virtual IO = 0xfec00000 */ > +#define io_v2p(va) ((va) - IO_OFFSET) > > I am not sure if these changes are right fix for the above error. io_v2p is define in davinci's mach/hardware.h so I believe this is what you should include in davinci_voicecodec.h. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists