linux-kernel - Re: [PATCH 3/3] sched: remove WARN_ON(!sd) from init_sched_groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130618100340.GM3204@twins.programming.kicks-ass.net>
Date:	Tue, 18 Jun 2013 12:03:40 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	mingo@...hat.com, linaro-kernel@...ts.linaro.org,
	patches@...aro.org, linux-kernel@...r.kernel.org,
	robin.randhawa@....com, Steve.Bannister@....com,
	Liviu.Dudau@....com, charles.garcia-tobin@....com,
	arvind.chauhan@....com
Subject: Re: [PATCH 3/3] sched: remove WARN_ON(!sd) from
 init_sched_groups_power()

On Tue, Jun 11, 2013 at 04:32:45PM +0530, Viresh Kumar wrote:
> sd can't be NULL in init_sched_groups_power() and so checking it for NULL isn't
> useful. In case it is required, then also we need to rearrange the code a bit as
> we already accessed invalid pointer sd to get sg: sg = sd->groups.
> 

Err on the side of paranoia :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/