linux-kernel - Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Jun 2013 16:30:43 +0200
From:	Pavel Machek <pavel@...x.de>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	dzu@...x.de, hjk@...sjkoch.de, grant.likely@...retlab.ca,
	rob.herring@...xeda.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices
 using command line option

On Tue 2013-06-18 15:02:16, Pavel Machek wrote:
> On Mon 2013-06-17 10:37:38, Greg KH wrote:
> > On Mon, Jun 17, 2013 at 03:47:41PM +0200, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > This adds ability to bind uio driver to given open firmware device
> > > > using command line option. Thus, userspace driver can be developed and
> > > > used without modifying the kernel.
> > > > 
> > > > Signed-off-by: Pavel Machek <pavel@...x.de> 
> > > 
> > > Ping? Greg, could you apply this patch? Or is there someone else I
> > > should ask to apply it?
> > 
> > Ugh, Hans seems to have dropped off of the net for a long time now, so I
> > guess I'll start queueing up UIO patches again.  Care to resend this?
> 
> Here you go. It still applies to your -next tree.

And here's version that removes "const" that is no longer true. I
missed the compile warning before. Sorry,
								Pavel

-(cut here)-

This adds ability to bind uio driver to given open firmware device
using command line option. Thus, userspace driver can be developed and
used without modifying the kernel.

Signed-off-by: Pavel Machek <pavel@...x.de>
Tested-by: Detlev Zundel <dzu@...x.de>

diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
index d594dd9..9741549 100644
--- a/drivers/uio/uio_pdrv_genirq.c
+++ b/drivers/uio/uio_pdrv_genirq.c
@@ -258,10 +258,14 @@ static const struct dev_pm_ops uio_pdrv_genirq_dev_pm_ops = {
 };
 
 #ifdef CONFIG_OF
-static const struct of_device_id uio_of_genirq_match[] = {
-	{ /* empty for now */ },
+static struct of_device_id uio_of_genirq_match[] = {
+	{ /* This is filled with module_parm */ },
+	{ /* Sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
+
+module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
+MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
 #else
 # define uio_of_genirq_match NULL
 #endif


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/