linux-kernel - Re: [ext3,ext4] old bug in htree_dirblock_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130618160120.GG7359@thunk.org>
Date:	Tue, 18 Jun 2013 12:01:20 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jan Kara <jack@...e.cz>
Subject: Re: [ext3,ext4] old bug in htree_dirblock_to_tree()

On Mon, Jun 17, 2013 at 04:23:38PM +0100, Al Viro wrote:
> 	Both ext3 and ext4 htree_dirblock_to_tree() is just filling
> the in-core rbtree for use by call_filldir().  All updates of
> ->f_pos are done by the latter; bumping it here (on error) is obviously
> wrong - we might very well have it nowhere near the block we'd found
> an error in.
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Applied, thanks.  Nice catch!

Jan, I'll carry the fix for ext3 as well in the ext4 tree, unless
you'd prefer otherwise.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/