linux-kernel - Re: [PATCHv2 2/2]misc: Use schedule_(raw_)spin_unlock and schedule_(raw_)spin_unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371572327.18733.37.camel@gandalf.local.home>
Date:	Tue, 18 Jun 2013 12:18:47 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Kirill Tkhai <tkhai@...dex.ru>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCHv2 2/2]misc: Use schedule_(raw_)spin_unlock and
 schedule_(raw_)spin_unlock_irq

On Tue, 2013-06-18 at 20:03 +0400, Kirill Tkhai wrote:
> Use helpers where possible (All directories except arch/.)

Also, this change log needs to be a bit better. Do not assume that
people have read the previous change. A year from now, when someone does
a git blame and sees this change, they will probably curse at this
explanation.

Add here the explanation that spin_unlock() calls preempt_enable() which
can schedule. But there are several locations that explicitly call
schedule after unlocking a spin lock. To prevent the double schedule,
use this schedule_spin_unlock() API.

-- Steve

> 
> Signed-off-by: Kirill Tkhai <tkhai@...dex.ru>
> CC: Steven Rostedt <rostedt@...dmis.org>
> CC: Ingo Molnar <mingo@...hat.com>
> CC: Peter Zijlstra <peterz@...radead.org>
> CC: LKML

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/