linux-kernel - Re: [PATCH v3 2/6] mm/writeback: Don't check force_wait to handle bdi->work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130618190027.GF1596@htj.dyndns.org>
Date:	Tue, 18 Jun 2013 12:00:27 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Michal Hocko <mhocko@...e.cz>,
	David Rientjes <rientjes@...gle.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Rik van Riel <riel@...hat.com>,
	Andrew Shewmaker <agshew@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Namjae Jeon <linkinjeon@...il.com>, Jan Kara <jack@...e.cz>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/6] mm/writeback: Don't check force_wait to handle
 bdi->work_list

On Tue, Jun 18, 2013 at 07:33:38PM +0800, Wanpeng Li wrote:
> After commit 839a8e86("writeback: replace custom worker pool implementation
> with unbound workqueue"), bdi_writeback_workfn runs off bdi_writeback->dwork,
> on each execution, it processes bdi->work_list and reschedules if there are
> more things to do instead of flush any work that race with us existing. It is
> unecessary to check force_wait in wb_do_writeback since it is always 0 after
> the mentioned commit. This patch remove the force_wait in wb_do_writeback.
> 
> Signed-off-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>

Reviewed-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/