linux-kernel - [PATCH 3.4.y] bonding: rlb mode of bond should not alter ARP originating via bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130618193334.GC29083@hv11.core.ecsorl.com>
Date:	Tue, 18 Jun 2013 15:33:34 -0400
From:	liquidhorse@...il.com
To:	netdev@...r.kernel.org
Cc:	zheng.x.li@...cle.com, fubar@...ibm.com, andy@...yhouse.net,
	davem@...emloft.net, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: [PATCH 3.4.y] bonding: rlb mode of bond should not alter ARP
 originating via bridge

From: zheng.li <zheng.x.li@...cle.com>

[ Upstream commit 567b871e503316b0927e54a3d7c86d50b722d955 ]

Do not modify or load balance ARP packets passing through balance-alb
mode (wherein the ARP did not originate locally, and arrived via a bridge).

Modifying pass-through ARP replies causes an incorrect MAC address
to be placed into the ARP packet, rendering peers unable to communicate
with the actual destination from which the ARP reply originated.

Load balancing pass-through ARP requests causes an entry to be
created for the peer in the rlb table, and bond_alb_monitor will
occasionally issue ARP updates to all peers in the table instrucing them
as to which MAC address they should communicate with; this occurs when
some event sets rx_ntt.  In the bridged case, however, the MAC address
used for the update would be the MAC of the slave, not the actual source
MAC of the originating destination.  This would render peers unable to
communicate with the destinations beyond the bridge.

Signed-off-by: Matthew O'Connor <liquidhorse@...il.com>
CC: Zheng Li <zheng.x.li@...cle.com>
Cc: Jay Vosburgh <fubar@...ibm.com>
Cc: Andy Gospodarek <andy@...yhouse.net>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org

View attachment "balance-alb-3.4.patch" of type "text/x-diff" (3138 bytes)