linux-kernel - Re: [PATCH] ACPI / dock: Take ACPI scan lock in write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7930194.VHtf9LiNRh@vostro.rjw.lan>
Date:	Tue, 18 Jun 2013 23:43:27 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Toshi Kani <toshi.kani@...com>
Cc:	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiang Liu <liuj97@...il.com>, Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH] ACPI / dock: Take ACPI scan lock in write_undock()

On Tuesday, June 18, 2013 03:28:37 PM Toshi Kani wrote:
> On Sun, 2013-06-16 at 00:16 +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > 
> > Since commit 3757b94 (ACPI / hotplug: Fix concurrency issues and
> > memory leaks) acpi_bus_scan() and acpi_bus_trim() must always be
> > called under acpi_scan_lock, but currently the following scenario
> > violating that requirement is possible:
> > 
> >  write_undock()
> >   handle_eject_request()
> >    hotplug_dock_devices()
> >     dock_remove_acpi_device()
> >      acpi_bus_trim()
> > 
> > Fix that by making write_undock() acquire acpi_scan_lock before
> > calling handle_eject_request() as appropriate (begin_undock() is
> > under the lock too in analogy with acpi_dock_deferred_cb()).
> > 
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Looks good.
> 
> Acked-by: Toshi Kani <toshi.kani@...com>

Thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/