linux-kernel - Re: [PATCH] build some drivers only when compile-testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51C15B99.6000701@ti.com>
Date:	Wed, 19 Jun 2013 10:19:53 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	Jeff Mahoney <jeffm@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<jirislaby@...il.com>, <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	<linux-usb@...r.kernel.org>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	<linux-geode@...ts.infradead.org>, <linux-fbdev@...r.kernel.org>,
	Richard Cochran <richardcochran@...il.com>,
	<netdev@...r.kernel.org>, Ben Hutchings <ben@...adent.org.uk>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>,
	Michal Marek <mmarek@...e.cz>
Subject: Re: [PATCH] build some drivers only when compile-testing

On 19/06/13 10:12, Jiri Slaby wrote:
> On 06/19/2013 09:10 AM, Tomi Valkeinen wrote:
>> On 17/06/13 23:05, Jiri Slaby wrote:
>>
>>> The last point I inclined to the Greg's argument to remove the
>>> EXPERT dependency.
>>>
>>> So currently I have what is attached... Comments?
>>
>> The patch looks a bit odd with the USB_CHIPIDEA_IMX parts. You're
>> not adding COMPILE_TEST there, but you're adding a totally new
>> config option, and also changing the Makefile.
> 
> Look:
> 
> +config USB_CHIPIDEA_IMX
> +       bool "ChipIdea IMX support"
> +       depends on OF_DEVICE && (ARM || COMPILE_TEST)
> 
> COMPILE_TEST added here ----------------^^^^^^^^^^^^

My point was that you're not adding COMPILE_TEST to an existing config
option, you're creating a totally new config option.

As I said, that's probably ok, but it'd be nice to mention extra things
like that in the desc. The pedantic approach would be to do the makefile
and Kconfig change in an earlier patch, and then add only COMPILE_TEST.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)