linux-kernel - Re: [PATCH 2/2] spi/pxa2xx: use a flag to check if the device is runtime suspended

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130619092310.GS1403@sirena.org.uk>
Date:	Wed, 19 Jun 2013 10:23:10 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Eric Miao <eric.y.miao@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH 2/2] spi/pxa2xx: use a flag to check if the device is
 runtime suspended

On Wed, Jun 19, 2013 at 10:44:37AM +0300, Mika Westerberg wrote:

> I agree that it is better handled outside of the driver (or provide some
> API for drivers). One thing that immediately came to mind is
> adding pm_runtime_suspending() that could be used here like:

> ssp_int()
> {
> 	if (pm_runtime_suspending(dev) || pm_runtime_suspending(dev))
> 		return IRQ_NONE;
> 	...

> or something like that?

Yes, something like that (probably include the suspended state in the
suspending check).

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)