linux-kernel - Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130619094828.GU1403@sirena.org.uk>
Date:	Wed, 19 Jun 2013 10:48:28 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Kevin Strasser <kevin.strasser@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Darren Hart <dvhart@...ux.intel.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Michael Brunner <Michael.Brunner@...tron.com>,
	Michael Brunner <mibru@....de>,
	Chris Healy <chealy@...co-us.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Dirk Hohndel <Dirk.Hohndel@...el.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Ben Dooks <ben-linux@...ff.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

On Wed, Jun 19, 2013 at 11:11:27AM +0200, Samuel Ortiz wrote:
> On Wed, Jun 19, 2013 at 10:40:04AM +0200, Linus Walleij wrote:

> > Not really my business, but I think if I was to implement this
> > inter-module API I would use regmap for this read/write marshalling
> > right here.

> I thought about this one and was under the impression that the regmap
> API would not let us implement this kind of stuff. I don't see how the
> reg_read and reg_write hooks would allow us to implement that, but I may
> be missing something here. Maybe Mark can provide some more input.

You should be able to use reg_read() and reg_write() but you're right it
would be a bit hoop jumping.  Really the code looks like a new generic
bus type for ioread()/iowrite() users though - I guess there will be
other similar devices connected in the same way and they probably don't
have radically different ideas about registers.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)