linux-kernel - Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Jun 2013 14:43:09 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	"'Thomas Petazzoni'" <thomas.petazzoni@...e-electrons.com>,
	"'Jason Gunthorpe'" <jgunthorpe@...idianresearch.com>,
	linux-samsung-soc@...r.kernel.org,
	"'Siva Reddy Kallam'" <siva.kallam@...sung.com>,
	"'Surendranath Gurivireddy Balla'" <suren.reddy@...sung.com>,
	linux-pci@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	"'Thierry Reding'" <thierry.reding@...onic-design.de>,
	linux-kernel@...r.kernel.org,
	"'Grant Likely'" <grant.likely@...retlab.ca>,
	"'Kukjin Kim'" <kgene.kim@...sung.com>,
	"'Thomas Abraham'" <thomas.abraham@...aro.org>,
	"'Bjorn Helgaas'" <bhelgaas@...gle.com>,
	"'Andrew Murray'" <andrew.murray@....com>
Subject: Re: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos

On Wednesday 19 June 2013, Jingoo Han wrote:
> Then, do you mean the following?
> 
> static int __exit exynos_pcie_remove(struct platform_device *pdev)
> {
>         struct pcie_port *pp = platform_get_drvdata(pdev);
> 
>         clk_disable_unprepare(pp->bus_clk);
>         clk_disable_unprepare(pp->clk);
> 
>         return 0;
> }
> 
> static struct platform_driver exynos_pcie_driver = {
>         .remove = __exit_p(exynos_pcie_remove),
> 
> [.....]
> 
> /* Exynos PCIe driver does not allow module unload */
> 
> static int __init pcie_init(void)
> {
>         hook_fault_code(16 + 6, exynos_pcie_abort, SIGBUS, 0,
>                         "imprecise external abort");
> 
>         platform_driver_probe(&exynos_pcie_driver, exynos_pcie_probe);
> 
>         return 0;
> }
> subsys_initcall(pcie_init);
> 
> MODULE_AUTHOR("Jingoo Han <jg1.han@...sung.com>");
> MODULE_DESCRIPTION("Samsung PCIe host controller driver");
> MODULE_LICENSE("GPLv2");
> 

Yes, this looks good. I would probably use platform_driver_register
rather than platform_driver_probe, but that is your choice. using
platform_driver_probe() mean you cannot deal with deferred probing.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/