linux-kernel - Re: [PATCH v2 2/4] lib/scatterlist: introduce sg_pcopy_from_buffer() and sg_pcopy_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC5umyivGS88R8SXoeqmgGkZFHDfN3GkaojDkfnbdX+NODwRyQ@mail.gmail.com>
Date:	Wed, 19 Jun 2013 22:12:29 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Imre Deak <imre.deak@...el.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Douglas Gilbert <dgilbert@...erlog.com>,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH v2 2/4] lib/scatterlist: introduce sg_pcopy_from_buffer()
 and sg_pcopy_to_buffer()

2013/6/18 Tejun Heo <tj@...nel.org>:
> On Tue, Jun 18, 2013 at 10:31:32PM +0900, Akinobu Mita wrote:
>>  /**
>> + * sg_miter_seek - reposition mapping iterator
>> + * @miter: sg mapping iter to be seeked
>> + * @offset: number of bytes to plus the current location
>> + *
>> + * Description:
>> + *   Sets the offset of @miter to its current location plus @offset bytes.
>> + *
>> + * Notes:
>> + *   This function must be called just after sg_miter_start() or sg_miter_stop()
>
> It's not gonna be hard to make this function to handle any state,
> right?  Wouldn't it be better to do that?  It's a pretty generic
> feature after all.  Also, maybe a better name is sg_miter_skip()?

Yes.  This limitation can be removed by calling sg_miter_stop() at
the front of sg_miter_seek().  Also, renaming it to sg_miter_skip()
sounds good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/