linux-kernel - Re: [PATCH v3] sound/sgtl5000: fix codec register initial values and handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130619152648.GW1403@sirena.org.uk>
Date:	Wed, 19 Jun 2013 16:26:48 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Oskar Schirmer <oskar@...ra.com>
Cc:	Fabio Estevam <fabio.estevam@...escale.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Zeng Zhaoming <zengzm.kernel@...il.com>,
	alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
	Takashi Iwai <tiwai@...e.de>, Jaroslav Kysela <perex@...ex.cz>,
	Wolfram Sang <w.sang@...gutronix.de>
Subject: Re: [PATCH v3] sound/sgtl5000: fix codec register initial values and
 handling

On Wed, Jun 19, 2013 at 01:16:06PM +0000, Oskar Schirmer wrote:

This is a set of three unrelated changes, they should be sent as three
separate patches.

> Further, mask computation in declarative part is obviously wrong:
> Fix FRAC DIVISOR to provide an 11 bit mask correctly.

What makes you say that this is obviously wrong?  It's not entirely
clear.

> -#define SGTL5000_PLL_FRAC_DIV_MASK		0x0700
> +#define SGTL5000_PLL_FRAC_DIV_MASK		0x07ff

Based on your changelog I was expecting a mask with only two bits set
here?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)