linux-kernel - Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130619203515.GB5594@roeck-us.net>
Date:	Wed, 19 Jun 2013 13:35:15 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Kevin Strasser <kevin.strasser@...ux.intel.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Darren Hart <dvhart@...ux.intel.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Michael Brunner <Michael.Brunner@...tron.com>,
	Michael Brunner <mibru@....de>,
	Chris Healy <chealy@...co-us.com>,
	Dirk Hohndel <Dirk.Hohndel@...el.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Ben Dooks <ben-linux@...ff.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...aro.org>,
	Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

On Wed, Jun 19, 2013 at 11:03:46AM -0700, Kevin Strasser wrote:
> On Wed, Jun 19, 2013 at 11:12:09AM +0200, Thomas Gleixner wrote:
> > On Tue, 18 Jun 2013, Kevin Strasser wrote:
> > 
> > This patch set looks reasonable now, except a formal issue.
> >  
> > > Signed-off-by: Kevin Strasser <kevin.strasser@...ux.intel.com>
> > > Signed-off-by: Michael Brunner <michael.brunner@...tron.com>
> > 
> > This is wrong, as it says:
> > 
> >  Kevin authored the code, sent it to Michael and Michael sent it to
> >  LKML.
> > 
> > 
> > The original code was authored by Michael. This version was authored
> > by Kevin based on Michaels code.
> > 
> > So either you keep Michael as the author, then you want 
> > 
> >  From: Michael Brunner <michael.brunner@...tron.com>
> > 
> >  <patch description/>
> > 
> >  Signed-off-by: Michael Brunner <michael.brunner@...tron.com>
> >  Signed-off-by: Kevin Strasser <kevin.strasser@...ux.intel.com>
> > 
> > or you decide that it's a major rewrite by you, then you want:
> > 
> >  This patch is based on the original version authored by
> >  Michael Brunner <michael.brunner@...tron.com>.
> > 
> >  Signed-off-by: Kevin Strasser <kevin.strasser@...ux.intel.com>
> > 
> >  Or 
> > 
> >  Originally-From: Michael Brunner <michael.brunner@...tron.com>.
> >  Signed-off-by: Kevin Strasser <kevin.strasser@...ux.intel.com>
> 
> Ok, I think this will make sense for all the patches except gpio,
> which is a major rewrite by Guenter.
> 
> So maybe this would be appropriate:
> 
>  From: Guenter Roeck <linux@...ck-us.net>
> 
>  <patch description>
> 
>  Originally-From: Michael Brunner <michael.brunner@...tron.com>
>  Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>  Signed-off-by: Kevin Strasser <kevin.strasser@...ux.intel.com>
>  ...

Ok with me. Always happy to take the blame :)

Thanks,
Guenter

> 
> Thanks,
> Kevin
> 
> > 
> > Other than that.
> > 
> > Acked-by: Thomas Gleixner <tglx@...utronix.de>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/