linux-kernel - RE: [PATCH v16 4/4] trace,x86: Add irq vector tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A5ED84D3BB3A384992CBB9C77DEDA4D41B04BAA8@USINDEM103.corp.hds.com>
Date:	Wed, 19 Jun 2013 21:01:20 +0000
From:	Seiji Aguchi <seiji.aguchi@....com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hpa@...or.com" <hpa@...or.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...e.hu" <mingo@...e.hu>, "bp@...en8.de" <bp@...en8.de>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	Tomoki Sekiyama <tomoki.sekiyama@....com>,
	"dle-develop@...ts.sourceforge.net" 
	<dle-develop@...ts.sourceforge.net>
Subject: RE: [PATCH v16 4/4] trace,x86: Add irq vector tracepoints


> On Tue, 2013-06-18 at 15:01 -0400, Seiji Aguchi wrote:
> >  /*
> >   * the load_current_idt() is called with interrupt disabled by
> > local_irq_save()
> >   * to avoid races. That way the IDT will always be set back to the
> > expected
> > @@ -442,6 +508,8 @@ static inline void load_current_idt(void)
> >         local_irq_save(flags);
> >         if (is_debug_idt_enabled())
> >                 load_debug_idt();
> > +       if (is_trace_idt_enabled())
> > +               load_trace_idt();
> 
> This should be:
> 
> 	else if (is_trace_idt_enabled())
> 
> Otherwise, you just totally negated the previous if.

Thank you for testing my patch.
I will fix it.

Seiji