linux-kernel - Re: [PATCH v2] Make transparent hugepages cpuset aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1306191419081.13015@chino.kir.corp.google.com>
Date:	Wed, 19 Jun 2013 14:24:07 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Robin Holt <holt@....com>
cc:	Alex Thorlton <athorlton@....com>, linux-kernel@...r.kernel.org,
	Li Zefan <lizefan@...wei.com>, Rob Landley <rob@...dley.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>,
	linux-doc@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2] Make transparent hugepages cpuset aware

On Wed, 19 Jun 2013, Robin Holt wrote:

> The convenience being that many batch schedulers have added cpuset
> support.  They create the cpuset's and configure them as appropriate
> for the job as determined by a mixture of input from the submitting
> user but still under the control of the administrator.  That seems like
> a fairly significant convenience given that it took years to get the
> batch schedulers to adopt cpusets in the first place.  At this point,
> expanding their use of cpusets is under the control of the system
> administrator and would not require any additional development on
> the batch scheduler developers part.
> 

You can't say the same for memcg?

> Here are the entries in the cpuset:
> cgroup.event_control  mem_exclusive    memory_pressure_enabled  notify_on_release         tasks
> cgroup.procs          mem_hardwall     memory_spread_page       release_agent
> cpu_exclusive         memory_migrate   memory_spread_slab       sched_load_balance
> cpus                  memory_pressure  mems                     sched_relax_domain_level
> 
> There are scheduler, slab allocator, page_cache layout, etc controls.

I think this is mostly for historical reasons since cpusets were 
introduced before cgroups.

> Why _NOT_ add a thp control to that nicely contained central location?
> It is a concise set of controls for the job.
> 

All of the above seem to be for cpusets primary purpose, i.e. NUMA 
optimizations.  It has nothing to do with transparent hugepages.  (I'm not 
saying thp has anything to do with memcg either, but a "memory controller" 
seems more appropriate for controlling thp behavior.)

> Maybe I am misunderstanding.  Are you saying you want to put memcg
> information into the cpuset or something like that?
> 

I'm saying there's absolutely no reason to have thp controlled by a 
cpuset, or ANY cgroup for that matter, since you chose not to respond to 
the question I asked: why do you want to control thp behavior for certain 
static binaries and not others?  Where is the performance regression or 
the downside?  Is it because of max_ptes_none for certain jobs blowing up 
the rss?  We need information, and even if were justifiable then it 
wouldn't have anything to do with ANY cgroup but rather a per-process 
control.  It has nothing to do with cpusets whatsoever.

(And I'm very curious why you didn't even cc the cpusets maintainer on 
this patch in the first place who would probably say the same thing.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/