linux-kernel - Re: [PATCH V6 15/30] thermal: exynos: Return success even if no cooling data supplied

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51C2369D.1090303@ti.com>
Date:	Wed, 19 Jun 2013 18:54:21 -0400
From:	Eduardo Valentin <eduardo.valentin@...com>
To:	Amit Daniel Kachhap <amit.daniel@...sung.com>
CC:	<linux-pm@...r.kernel.org>, Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <eduardo.valentin@...com>,
	<linux-samsung-soc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <amit.kachhap@...il.com>,
	Kukjin Kim <kgene.kim@...sung.com>, <jonghwa3.lee@...sung.com>
Subject: Re: [PATCH V6 15/30] thermal: exynos: Return success even if no cooling
 data supplied

On 17-06-2013 02:46, Amit Daniel Kachhap wrote:
> This patch removes the error return in the bind/unbind routine
> as the platform may not register any cpufreq cooling data.
> 
> Acked-by: Kukjin Kim <kgene.kim@...sung.com>
> Acked-by: Jonghwa Lee <jonghwa3.lee@...sung.com>
> Signed-off-by: Amit Daniel Kachhap <amit.daniel@...sung.com>
> ---
>  drivers/thermal/samsung/exynos_thermal_common.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c
> index 7064eb7..86d39aa 100644
> --- a/drivers/thermal/samsung/exynos_thermal_common.c
> +++ b/drivers/thermal/samsung/exynos_thermal_common.c
> @@ -131,7 +131,7 @@ static int exynos_bind(struct thermal_zone_device *thermal,
>  	tab_size = data->cooling_data.freq_clip_count;
>  
>  	if (tab_ptr == NULL || tab_size == 0)
> -		return -EINVAL;
> +		return 0;
>  
>  	/* find the cooling device registered*/
>  	for (i = 0; i < th_zone->cool_dev_size; i++)
> @@ -180,7 +180,7 @@ static int exynos_unbind(struct thermal_zone_device *thermal,
>  	tab_size = data->cooling_data.freq_clip_count;
>  
>  	if (tab_size == 0)
> -		return -EINVAL;
> +		return 0;
>  
>  	/* find the cooling device registered*/
>  	for (i = 0; i < th_zone->cool_dev_size; i++)
> 

I have one question before acking this one: what happens if one
registers a TMU with no freq tab? Say the case where you have three
sensors, just like SOC_ARCH_EXYNOS5440. Would you register
cpufreq_cooling device for all of them? In other way, are you having 3
cpufreq_cooling devices?


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


Download attachment "signature.asc" of type "application/pgp-signature" (296 bytes)