linux-kernel - Re: [PATCH] mv643xx_eth: Fix a DMA-API error handling warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130619.221815.1630968197223302672.davem@davemloft.net>
Date:	Wed, 19 Jun 2013 22:18:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	lkundrak@...sk
Cc:	buytenh@...tstofly.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mv643xx_eth: Fix a DMA-API error handling warning

From: Lubomir Rintel <lkundrak@...sk>
Date: Tue, 18 Jun 2013 19:33:28 +0200

> We check the failure status just prior to unmap, since it would be too much of
> a hassle to roll back commands we already started to enqueue if we handled it
> just after the map.
> 
> This way we at least avoid a lockup on reclaim, the card presumably didn't
> succeed DMA-ing to a bogus address anyway.

You have to handle it at map time, I don't care how complicated it is.

As is, when a DMA mapping failure occurs the chip is crapping into
random memory.  At that point, who cares what you decide to do about
it at unmap time?

This patch is unacceptable, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/