linux-kernel - Re: [PATCH 1/2] perf tools: fix a typo of a Power7 event name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371691282.21846.1.camel@concordia>
Date:	Thu, 20 Jun 2013 11:21:22 +1000
From:	Michael Ellerman <michael@...erman.id.au>
To:	Runzhen Wang <runzhen@...ux.vnet.ibm.com>
Cc:	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	paulus@...ba.org, acme@...hat.com, sukadev@...ux.vnet.ibm.com,
	xiaoguangrong@...ux.vnet.ibm.com, icycoder@...il.com
Subject: Re: [PATCH 1/2] perf tools: fix a typo of a Power7 event name

On Wed, 2013-06-19 at 17:15 +0800, Runzhen Wang wrote:
> In the Power7 PMU guide:
> https://www.power.org/documentation/commonly-used-metrics-for-performance-analysis/
> PM_BRU_MPRED is referred to as PM_BR_MPRED.
> 
> This patch fix the typo by changing the name of the event in kernel and
> documentation accordingly.
> 
> Signed-off-by: Runzhen Wang <runzhen@...ux.vnet.ibm.com>
> ---
>  .../testing/sysfs-bus-event_source-devices-events  |    2 +-
>  arch/powerpc/perf/power7-pmu.c                     |   12 ++++++------
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> index 8b25ffb..3c1cc24 100644
> --- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> +++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> @@ -29,7 +29,7 @@ Description:	Generic performance monitoring events
>  
>  What: 		/sys/devices/cpu/events/PM_1PLUS_PPC_CMPL
>  		/sys/devices/cpu/events/PM_BRU_FIN
> -		/sys/devices/cpu/events/PM_BRU_MPRED
> +		/sys/devices/cpu/events/PM_BR_MPRED

So you're changing the ABI.

I think that's probably OK, but you at least need to mention _why_ you
think it's OK.

cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/