[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130620132003.GD24993@verge.net.au>
Date: Thu, 20 Jun 2013 22:20:03 +0900
From: Simon Horman <horms@...ge.net.au>
To: Julian Anastasov <ja@....bg>
Cc: Alexander Frolkin <avf@...amar.org.uk>, lvs-devel@...r.kernel.org,
Wensong Zhang <wensong@...ux-vs.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipvs: SH fallback and L4 hashing
On Wed, Jun 19, 2013 at 10:45:43PM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Wed, 19 Jun 2013, Alexander Frolkin wrote:
>
> > By default the SH scheduler rejects connections that are hashed onto a
> > realserver of weight 0. This patch adds a flag to make SH choose a
> > different realserver in this case, instead of rejecting the connection.
> >
> > The patch also adds a flag to make SH include the source port (TCP, UDP,
> > SCTP) in the hash as well as the source address. This basically allows
> > for deterministic round-robin load balancing (i.e., where any director
> > in a cluster of directors with identical config will send the same
> > packet the same way).
> >
> > The flags are service flags (IP_VS_SVC_F_SCHED*) so that these options
> > can be set per service. They are set using a new option to ipvsadm.
> >
> > Signed-off-by: Alexander Frolkin <avf@...amar.org.uk>
>
> Thanks! Looks good to me.
>
> Acked-by: Julian Anastasov <ja@....bg>
>
> > ---
> > The patch is against the ipvs-next tree.
>
> Still, I see one warning:
>
> patching file include/uapi/linux/ip_vs.h
> patching file net/netfilter/ipvs/ip_vs_sh.c
> Hunk #2 succeeded at 75 with fuzz 1.
>
> May be because you are missing the
> "ipvs: ip_vs_sh: fix build" change, not sure where is
> the fault, may be the change is not in ipvs-next,
> Simon can tell how to proceed with applying this patch.
Thanks, applied and pushed to ipvs-next.
I also noticed some fuzz.
Alexander, could you double-check ipvs-next to make sure
that I applied the patch correctly?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists