linux-kernel - Re: [PATCH V8 1/4] pci: Add PCIe driver for Samsung Exynos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201306201520.49212.arnd@arndb.de>
Date:	Thu, 20 Jun 2013 15:20:48 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	"'Kukjin Kim'" <kgene.kim@...sung.com>,
	"'Bjorn Helgaas'" <bhelgaas@...gle.com>,
	linux-samsung-soc@...r.kernel.org, linux-pci@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	"'Grant Likely'" <grant.likely@...retlab.ca>,
	"'Andrew Murray'" <andrew.murray@....com>,
	"'Thomas Petazzoni'" <thomas.petazzoni@...e-electrons.com>,
	"'Thierry Reding'" <thierry.reding@...onic-design.de>,
	"'Jason Gunthorpe'" <jgunthorpe@...idianresearch.com>,
	"'Surendranath Gurivireddy Balla'" <suren.reddy@...sung.com>,
	"'Siva Reddy Kallam'" <siva.kallam@...sung.com>,
	"'Thomas Abraham'" <thomas.abraham@...aro.org>,
	"'Tomasz Figa'" <t.figa@...sung.com>,
	"'Pratyush Anand'" <pratyush.anand@...com>,
	"'Mohit KUMAR'" <Mohit.KUMAR@...com>
Subject: Re: [PATCH V8 1/4] pci: Add PCIe driver for Samsung Exynos

On Thursday 20 June 2013, Jingoo Han wrote:

> diff --git a/Documentation/devicetree/bindings/pci/exynos-pcie.txt b/Documentation/devicetree/bindings/pci/exynos-pcie.txt
> new file mode 100644
> index 0000000..f71d835
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/exynos-pcie.txt
> @@ -0,0 +1,73 @@
> +* Samsung Exynos PCIe interface

Please adapt the name of the binding as well, and name it snps-dwc-pcie.txt
for instance, to match the change in the driver and in the binding.

> +Required properties:
> +-compatible: should contain "snps,dwc-pcie" to identify the
> +	core, plus an identifier for the specific instance, such
> +	as "samsung,exynos5440-pcie".

Thanks for changing it here.

> +
> +	pcie@...000 {
> +		compatible = "samsung,exynos5440-pcie";
> +		reg = <0x290000 0x1000
> +			0x270000 0x1000
> +			0x271000 0x40>;


but please also change the example and the .dts files to match.
It should say here

		compatible = "samsung,exynos5440-pcie", "snps,dwc-pcie";

as now required by the binding.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/