linux-kernel - Re: [PATCH] intel_iommu: Downgrade the warning if enabling irq remapping fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130620142752.GA3496@8bytes.org>
Date:	Thu, 20 Jun 2013 16:27:52 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Fedora Kernel Team <kernel-team@...oraproject.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] intel_iommu: Downgrade the warning if enabling irq
 remapping fails

On Mon, May 13, 2013 at 03:22:42PM -0700, Andy Lutomirski wrote:
> This triggers on a MacBook Pro.
> 
> Signed-off-by: Andy Lutomirski <luto@...capital.net>
> https://bugzilla.redhat.com/show_bug.cgi?id=948262
> ---
>  drivers/iommu/intel_irq_remapping.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index f3b8f23..a7e0ad1 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -654,8 +654,7 @@ error:
>  	 */
>  
>  	if (x2apic_present)
> -		WARN(1, KERN_WARNING
> -			"Failed to enable irq remapping.  You are vulnerable to irq-injection attacks.\n");
> +		pr_warn("Failed to enable irq remapping.  You are vulnerable to irq-injection attacks.\n");
>  
>  	return -1;
>  }
> -- 
> 1.8.1.4

Applied to x86/vt-d, thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/